Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to P2 enhancements in Eclipse 2023-12 #3043

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Nov 15, 2023

And add tests for support of Product Update-site names from the tycho-4.0.x branch.

This can be submitted once the Eclipse 2023-12 SimRel, which includes the new P2 is released.

The back-port to Tycho 4 is done explicitly in #3125, since slightly different things have to be done.

pom.xml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 15, 2023

Test Results

382 files  ±0  382 suites  ±0   2h 42m 4s ⏱️ + 9m 6s
377 tests +1  371 ✔️ +2    6 💤 ±0  0 ±0 
754 runs  +2  741 ✔️ +3  13 💤 ±0  0 ±0 

Results for commit b5e1228. ± Comparison against base commit 23bbf9f.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member Author

HannesWell commented Dec 5, 2023

The test was failing because through some dependency paths (I didn't investigated which one exactly) old and new versions of the LocalMetadataRepository class ended up in tycho.core and the old version of the class of course didn't implement removeReferences(), which is why the test failed (so they are working).
In order to fix that I just bumped all p2 dependencies to their latest version with this PR.

Lets hope the build succeeds now.

@HannesWell
Copy link
Member Author

The test failures are a consequence of eclipse-equinox/p2#310, but tycho still uses pack.gz repositories:
https://github.com/eclipse-tycho/tycho/tree/master/tycho-core/src/test/resources/repositories/packgz

Created #3168 to adapt the tests.

And add tests for support of Product Update-site names from the
tycho-4.0.x branch.
@laeubi laeubi merged commit fce75f4 into eclipse-tycho:master Dec 10, 2023
9 of 10 checks passed
@HannesWell HannesWell deleted the adapt-to-p2-2023-12 branch December 10, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants